Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved user values to .env & added .gitignore #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

saarmstrong
Copy link

Hey man, hope this is not too presumptuous but I wanted to ask how you would feel about some small QoL suggestions:

  • Move the user specific values to a .env file that would allow the user to store their personal values without the fear of checking them in and publishing to github
  • Added a .gitignore file to prevent myself (and others) from accidentally checking in their .env and generated pycache files

I am (impatiently) waiting on my e-ink screen to arrive, but I have tested this locally and I see the expected console logs as I saw when I ran the command on your main branch.

@saarmstrong saarmstrong changed the title Moved user values to .env && updated .gitignore Moved user values to .env & added .gitignore Oct 5, 2020
@zoharsf
Copy link
Owner

zoharsf commented Oct 6, 2020

Not presumptuous at all, I'm glad to see someone improve upon my code.
I reviewed your changes, and they look good.
I'll clone the repo with your changes to my rpi and make sure everything works and then approve it.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants